Skip to content

Conversation

jmesserly
Copy link

No description provided.

@jmesserly
Copy link
Author

Did this as a pull request for easier previewing/editing.

Copy link
Member

@leafpetersen leafpetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

characters to the console on Windows. Calls to `Stdout.add*()` behave as
before.

### Strong Mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last few releases has had these under the top ###Language section, with the individual changes then calling out if they are strong mode specific or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But maybe this is different as these are semantic changes to existing language constructs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's a fair point! thoughts @leafpetersen ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, I had the same thought.

@jmesserly
Copy link
Author

Chatted with Leaf, he suggested I merge this then he'll combine with his other 1.23 language changes. Thanks all!

@jmesserly jmesserly merged commit 50be4c5 into master Mar 28, 2017
@jmesserly jmesserly deleted the changelog_for_strong_mode branch March 28, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants